Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11936] Add configuration parameter for suppressing error-prone UnusedVariable check #16010

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

TheNeuralBit
Copy link
Member

... and sets the parameter in every applyJavaNature usage.

This will enable breaking up the changes for this check into several smaller PRs.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

R: @kennknowles @benWize

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #16010 (7ffc904) into master (9fe2a27) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16010      +/-   ##
==========================================
- Coverage   83.62%   83.62%   -0.01%     
==========================================
  Files         445      445              
  Lines       61382    61382              
==========================================
- Hits        51329    51328       -1     
- Misses      10053    10054       +1     
Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 87.80% <0.00%> (-2.44%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 96.72% <0.00%> (-1.64%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.00% <0.00%> (-1.00%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.64% <0.00%> (+0.12%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.41% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe2a27...7ffc904. Read the comment docs.

@TheNeuralBit
Copy link
Member Author

Run Java_Examples_Dataflow PreCommit

@TheNeuralBit
Copy link
Member Author

Run Java PreCommit

@TheNeuralBit
Copy link
Member Author

Run Java_Examples_Dataflow PreCommit

@TheNeuralBit
Copy link
Member Author

Run Java_Examples_Dataflow PreCommit

@TheNeuralBit TheNeuralBit merged commit 6a13c4b into apache:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants