GH-43876: [CI][Swift] Use apache/arrow-go remote repository instead of arrow/go subfolder #44145
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcd
commented
Sep 17, 2024
| @@ -22,9 +22,11 @@ set -ex | |||
| data_gen_dir=${1}/swift/data-generator/swift-datagen | |||
| export GOPATH=/ | |||
| pushd ${data_gen_dir} | |||
| go get -d ./... | |||
| git clone https://github.com/apache/arrow-go.git /arrow-go | |||
There was a problem hiding this comment.
We could use a released tag but we can just clone main and find potential issues earlier. @kou any thoughts?
There was a problem hiding this comment.
How about doing this after we release a new version from apache/arrow-go?
I tried apache/arrow-go#87 for this issue but it didn't work.
There was a problem hiding this comment.
I wanted to remove /go subfolder before the Arrow release, if we do that we should release arrow-go before, was that your plan?
There was a problem hiding this comment.
Yes.
BTW, it seems that this script doesn't refer go/ in apache/arrow. It uses released version:
Line 21 in 1c1f7f3
This script may still work even if we remove go/ in apache/arrow.
github-actions
bot
added
awaiting changes
raulcd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Go implementation is moving to apache/arrow-go from go/ in apache/arrow.
What changes are included in this PR?
Use clone for apache/arrow-go instead of code from arrow/go subfolder
Are these changes tested?
Yes, CI
Are there any user-facing changes?
No