Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Airflow 3728] remove double comma in hive_hooks.py #4552

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

zhongjiajie
Copy link
Member

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • remove double comma in hive_hooks.py

Tests

  • My PR does not need testing for this extremely good reason: just remove double comma in hive_hooks.py

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@r39132
Copy link
Contributor

r39132 commented Jan 18, 2019

For minor changes, you can just use AIRFLOW-XXX as the jira - no need to create a JIRA.

@r39132 r39132 merged this pull request into apache:master Jan 18, 2019
r39132 pushed a commit that referenced this pull request Jan 18, 2019
@zhongjiajie
Copy link
Member Author

For minor changes, you can just use AIRFLOW-XXX as the jira - no need to create a JIRA.

@r39132 Ok, next time I will do that

@zhongjiajie zhongjiajie deleted the airflow_3728 branch January 19, 2019 02:39
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants