Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close state when emptyState is false and there is no suggestions #266

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

ido213
Copy link
Contributor

@ido213 ido213 commented Sep 10, 2024

I encored a bug, when the emptyState is false and there is no suggestion and the suggestion box was already open, it will show an empty suggestion box.

<AutoComplete emptyState={false}>
...

This small fix closes the suggestion box, in that case

Copy link

codesandbox bot commented Sep 10, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 4de1e1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

what-the-diff bot commented Sep 10, 2024

PR Summary

  • Autocomplete Function Updated
    The Autocomplete function that assists in predictive text input, has seen an improvement. This function will now actively check if the suggestions list based on what you are typing is empty. If it is empty and doesn't already display a message indicating this absence of suggestions, the system will alert you to this fact. Hence, providing you with an understanding that moving forward, no more suggestions can be made based on your current text input.

@Kysluss Kysluss self-requested a review September 12, 2024 00:49
@Kysluss Kysluss added the bug Something isn't working label Sep 12, 2024
@Kysluss Kysluss merged commit 2690b68 into anubra266:main Sep 12, 2024
1 check passed
@Kysluss
Copy link
Collaborator

Kysluss commented Sep 12, 2024

Thank you for the bug report and PR. v5.6.3 has been released with credit to you in the release notes.

Thank you for supporting this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants