Alpha 10 #17
Merged
Alpha 10 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 26, 2023 00:12
New translations for Arabic, Bengali, German, Spanish, Hindi, Japanese, Portuguese, Russian and Chinese have been added into the system. This will improve the user experience for people who use these languages as their primary language. The translations have been implemented across all strings throughout the application, including button labels and error messages."
Incorporated functions to handle actions within our scenesStore, allowing the addition and removal of actions, as well as their deletion from scenes. Introduced the 'Action' and 'RawAction' classes to facilitate these operations. Refactored 'update_script.rs' to create and truncate scripts properly. Updated 'Timeline.vue' to incorporate 'RawAction' with 'TimelineAction' component for better layout. Created a new 'Action.vue' component that provides a clear visual representation of action manipulation. Adjusted layout of 'edit.vue' and 'PageLayout.vue' for better utilization of space and manage overflow. These changes improve the management of actions within scenes and enhance the application's layout arrangement.
This commit introduces the order in which actions are performed in scenesStore.ts. An '_order' property has been added to the action object to manage this sequence. Functions to get an action by order, to update an action's order and to invert the order of two actions have also been implemented. Now, actions can be sorted and retrieved by their order. This change will facilitate a more structured management of actions and their execution sequence.
This commit updates 'Timeline.vue', 'Action.vue', and 'scene.ts' components and adds a new 'ActionBtn.vue' component to the scene directory. The main update is the addition of an '_order' property to the 'BaseElement' in scene.ts, which is used to manage the order of actions. This is particularly used to manage drag and drop functionality in 'Timeline.vue'. Moreover, some changes for code enhancement and bug fix were made in 'Timeline.vue' and 'Action.vue'. The paths and import statements were updated. We replaced the 'Icon' component with the new 'ActionBtn' component in 'Action.vue'. Also a 'deleteAction', 'orderUp', and 'orderDown' methods were added and others were improved. The 'ActionBtn.vue' component was added to replace the delete button functionality in the 'Action.vue' component with a more generic button that can be clicked to trigger any action. This was implemented making usability improvements for brake and improve maintainability. Lastly, a minor update in 'InputText.vue' to make the 'label' property optional. The changes represent significant improvements in the code maintainability, structure, and user interaction with the action elements in the application.
Reviewing the code changes, there are two main things addressed in this commit. Firstly, the functionality of Actions was improved to allow for their deletion, an important addition for better user experience and system's flexibility. This update is now reflected in the CHANGELOG.md. Secondly, several of our dependencies in package.json have been updated to their latest versions; this includes eslint-plugin-vue, sass, vue-i18n, and vue-tsc. Routinely updating our dependencies helps keep the project secure and up-to-date, ensuring we are using the most recent features, improvements, and security patches.
In this commit, the Vue's built-in `<TransitionGroup>` tag was included in the Timeline component, specifically wrapping the Action instances. This use of transition groups is for the purpose of providing animations when the list of actions is reordered or when an action is added or deleted. This improves the user interface by making it more interactive and intuitive. Additionally, a `key` attribute was added to the <TimelineAction> component as a good Vue practice.
In this commit, enhancements to the "Actions" section in Alpha 10 were updated, including improvements to deleting and ordering actions, quality of life updates, and added animations. Emojis were also added to the list of new translations for better readability. To enhance organization, separators were added between the alpha versions for improved readability.
Extended the functionality of the actions component to improve the user interaction and management of the different types of actions. Removed console log from 'inputValue' watcher in ActionRaw.vue. Added a new ActionElement type and updated the RawAction type in scene.ts for better type clarity. Created a new file actionsElements.ts to handle actions elements data. New component ActionJump.vue was added to handle Jump actions. Several updates across the codebase to adapt to the recent changes and improve interaction: updated logic in Timeline.vue to handle jump actions, updated Action.vue to handle new structure of action types, added conditions in InputSelect.vue to handle optional labels and updated pamyu.ts utilization for actions.
Extended the functionality of the actions component to improve the user interaction and management of the different types of actions. Removed console log from 'inputValue' watcher in ActionRaw.vue. Added a new ActionElement type and updated the RawAction type in scene.ts for better type clarity. Created a new file actionsElements.ts to handle actions elements data. New component ActionJump.vue was added to handle Jump actions. Several updates across the codebase to adapt to the recent changes and improve interaction: updated logic in Timeline.vue to handle jump actions, updated Action.vue to handle new structure of action types, added conditions in InputSelect.vue to handle optional labels and updated pamyu.ts utilization for actions.
Adding a 'message' functionality was essential to provide users with new interaction type. Now users can create a message action and specify a character in scenes. The 'message' action can be used without assigning it to a character as well. 'message' option was also added to the action type switch statement in Timeline.vue. Translations for 'message' and 'noCharacter' were also added for multiple languages.
The 'message' action type was added to the list of actions in actionsElements.ts while refining the code structure. In utils/tools.ts, the argument for getIndent function is now given a default value of 1. In utils/pamyu.ts, 'message' was added to the import statement and its corresponding functionality was implemented in the getMessageActionLines function. This is to enhance the interaction capabilities of users within scenes.
…order logic Two redundant properties, 'multiline' and 'withTyping', were removed from the 'message' action type in scene.ts file to streamline it. A logic was also added within the scenesStore.ts file to fix the order of actions post deletion of an action. The changes also include an enhancement in the ActionMessage.vue file where the message and character value update now takes place within a single 'watchEffect' instead of two separate 'watch' calls. These modifications enhance efficiency in action ordering and update methods.
Removed redundant properties, 'multiline' and 'withTyping', from the 'message' action type for simplification. Fixed the actions ordering logic post deletion of an action to ensure consistent sequence. Merged two separate 'watch' calls into a single 'watchEffect' within ActionMessage.vue for better performance with simultaneous updates of message and character value. Changes enhance efficiency and declutter code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.