Block deletion of resources with unprocessed events #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
force-pushed
the
more_event_blocking
branch
from
398a3d4
to
69eccd3
Compare
AlanCoding
changed the title
wwitzel3
approved these changes
Mar 16, 2018
| @@ -5,9 +5,17 @@ | |||
|
|
|||
| from django.utils.translation import ugettext_lazy as _ | |||
|
|
|||
| __all__ = [ | |||
| return UnifiedJob.objects.filter(instance_group=self, | ||
| status__in=ACTIVE_STATES) | ||
| def _get_related_jobs(self): | ||
| return UnifiedJob.objects.filter(instance_group=self) |
There was a problem hiding this comment.
Nice removing all of the extra filtering since the mixin already applies this filter.
chrismeyersfsu
pushed a commit
to chrismeyersfsu/awx
that referenced
this pull request
Apr 26, 2018
Add corresponding log for WorkflowJob submission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.