Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UI selects for Playbook, Project, and Organization Virtualenvs #1338

Merged
merged 2 commits into from
Feb 23, 2018

Conversation

marshmalien
Copy link
Member

SUMMARY

Add capability to select venv for, if you have rbac roles to edit:

  • Organization
  • Project
  • Job Template

Connect: #34

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • UI
ADDITIONAL INFORMATION
Job Template Example

screen shot 2018-02-23 at 1 42 48 pm

Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Should we do a ProcessErrors check within the resolve?

edit: {
ConfigData: ['ConfigService', (ConfigService) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProcessErrors?

Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@marshmalien marshmalien merged commit 434cd31 into ansible:devel Feb 23, 2018
@marshmalien marshmalien deleted the feat/multiple_venvs branch October 14, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants