Logger function in options #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config object passed as a param to the function `setup.compressed` was incomplete. I added a noop as the info logging function to make it green.
|
My bad: I didn't write documentation for this. Should I do that? |
|
yes please! documentation would be great |
|
you'll want to pull down the changes I just made to this... I cleaned up some conflicts in the code. |
designfrontier
approved these changes
Oct 7, 2017
|
Code looks great, just waiting on some documentation to get this merged. Thanks so much! @dottorblaster |
|
@designfrontier just pushed my README updates in fc2fd33, hope this is ok 👍 |
designfrontier
approved these changes
Oct 9, 2017
|
Strong Work! This looks fantastic. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #444, I'm implementing a pluggable logger with defaults going to trigger simple console invokes.
I updated tests too, hope this helps!