Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Implement util.throttle in slider #300

Closed
ajoslin opened this issue Sep 19, 2014 · 0 comments
Closed

Implement util.throttle in slider #300

ajoslin opened this issue Sep 19, 2014 · 0 comments
Labels
type: enhancement
Milestone
0.4

Comments

@ajoslin
Copy link
Contributor

ajoslin commented Sep 19, 2014

Timeouts can cause a DOM repaint, which kind of defeats the point of why we're using debounce in the first place: to stop the DOM from repainting during expensive operations!

We should just make a method that checks the current time versus the last time the function was called, and uses that to determine whether it should call again.
@ajoslin ajoslin modified the milestones: 0.0.3, 0.0.4 Sep 19, 2014
@ajoslin ajoslin self-assigned this Sep 19, 2014
@ajoslin ajoslin mentioned this issue Sep 19, 2014
Closed
@ajoslin ajoslin changed the title Util.debounce: make it not use a timeout Implement util.throttle in slider Sep 29, 2014
ajoslin added a commit that referenced this issue Oct 2, 2014
@ajoslin
fix(sidenav): add display: none; while closed
8f10401 
Closes #300. Closes #345.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@ajoslin