This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
angular.isElement does not return a boolean #4519
Comments
caitp
pushed a commit
to caitp/angular.js
that referenced
this issue
Oct 19, 2013
angular.isElement currently returns a truthy object/function, or false. This patch aims to correct this behaviour by casting the result of the isElement expression to a boolean value via double-negation. Closes angular#4519
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this issue
Jan 27, 2014
angular.isElement currently returns a truthy object/function, or false. This patch aims to correct this behaviour by casting the result of the isElement expression to a boolean value via double-negation. Closes angular#4519 Closes angular#4534
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this issue
Jan 27, 2014
angular.isElement currently returns a truthy object/function, or false. This patch aims to correct this behaviour by casting the result of the isElement expression to a boolean value via double-negation. Closes angular#4519 Closes angular#4534
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It appears this change happened during the JQLite rewrite a few years ago.
00cc9eb
I'm trying to use the method in unit tests and realized I couldn't test for equality, only truthiness.
The text was updated successfully, but these errors were encountered: