Fix axial_hex_distribution_*nn.py
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bugfix
* Sort import statements according to isort. * Format the code and docstrings of the defined functions.
Fix the search algorithms for finding the first column (function `get_1st_hex_face_col`) and the first two staggered rows (function `get_1st_hex_face_rows`) of a hexagonal lattice.
* Sort import statements according to isort. * Format the code and docstrings of the defined functions.
Fix the search algorithms for finding the first two staggered columns of a hexagonal lattice (function `get_1st_hex_face_cols`).
andthum
force-pushed
the
fix/scripts/structure/axial-hex-distribution
branch
from
35a5ef5
to
be89686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
axial_hex_distribution_*nn.pyType of change
Proposed changes
Scripts
axial_hex_distribution_1nn.pyandaxial_hex_distribution_2nn.py: Fix the search algorithms for finding the first column(s) and row(s) of a hexagonal lattice when the lattice faces lie (almost) exactly on the edges of the simulation box.PR checklist