Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arteficial discrete trajectories: Calculate Kaplan-Meier estimator #189

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

andthum
Copy link
Owner

@andthum andthum commented Nov 7, 2023

Arteficial discrete trajectories: Calculate Kaplan-Meier estimator

Type of change

  • Change of core package.
  • Change of scripts.
  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Proposed changes

  • misc/dtrj_lifetimes/compare_dtrj_lifetime_methods.py:
    • Additionally calculate lifetimes from the Kaplan-Meier estimate of the survival function.
    • Calculate first 4 raw moments of the lifetime distribution.
    • Plot the average residual lifetime.
    • Refactor code.
  • misc/dtrj_lifetimes/plot_lifetimes.py: Adapt to the changes in misc/dtrj_lifetimes/compare_dtrj_lifetime_methods.py.

PR checklist

  • I followed the guidelines in the Developer's guide.
  • New/changed code is properly tested.
  • New/changed code is properly documented.
  • The CI workflow is passing.

* Additionally calculate lifetimes from the Kaplan-Meier estimate of the
  survival function.
* Calculate first 4 raw moments.
* Refactor code.
* Additionally calculate lifetimes from the Kaplan-Meier estimate of the
  survival function.
* Calculate first 4 raw moments.
* Refactor code.
* Additionally calculate lifetimes from the Kaplan-Meier estimate of the
  survival function.
* Calculate first 4 raw moments.
* Plot the average residual lifetime.
* Refactor code.
* Additionally calculate lifetimes from the Kaplan-Meier estimate of the
  survival function.
* Calculate first 4 raw moments.
* Plot the average residual lifetime.
* Refactor code.
* Additionally calculate lifetimes from the Kaplan-Meier estimate of the
  survival function.
* Calculate first 4 raw moments.
* Plot the average residual lifetime.
* Refactor code.
* Additionally calculate lifetimes from the Kaplan-Meier estimate of the
  survival function.
* Calculate first 4 raw moments.
* Plot the average residual lifetime.
* Refactor code.
Adapt the script `plot_lifetimes.py` to the changes in
`compare_dtrj_lifetime_methods.py`.
@github-actions github-actions bot added the maintenance Project maintenance label Nov 7, 2023
@andthum andthum merged commit 87e371b into main Nov 7, 2023
19 checks passed
@andthum andthum deleted the feat/misc/dtrj-lifetimes/include-kaplan-meier branch November 7, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant