Skip to content

Commit

Permalink
Removed export macros from all internal prototypes.
Browse files Browse the repository at this point in the history
Details:
- After merging PR flame#303, at Isuru's request, I removed the use of
  BLIS_EXPORT_BLIS from all function prototypes *except* those that we
  potentially wish to be exported in shared/dynamic libraries. In other
  words, I removed the use of BLIS_EXPORT_BLIS from all prototypes of
  functions that can be considered private or for internal use only.
  This is likely the last big modification along the path towards
  implementing the functionality spelled out in issue flame#248. Thanks
  again to Isuru Fernando for his initial efforts of sprinkling the
  export macros throughout BLIS, which made removing them where
  necessary relatively painless. Also, I'd like to thank Tony Kelman,
  Nathaniel Smith, Ian Henriksen, Marat Dukhan, and Matthew Brett for
  participating in the initial discussion in issue flame#37 that was later
  summarized and restated in issue flame#248.
- CREDITS file update.
  • Loading branch information
fgvanzee authored and dzambare committed Aug 3, 2020
1 parent f381c9a commit e4d07f9
Show file tree
Hide file tree
Showing 153 changed files with 433 additions and 433 deletions.
20 changes: 10 additions & 10 deletions frame/0/bli_l0_check.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* chi, \
obj_t* psi \
Expand All @@ -57,7 +57,7 @@ GENTPROT( subsc )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* chi \
);
Expand All @@ -68,7 +68,7 @@ GENTPROT( invertsc )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* chi, \
obj_t* absq \
Expand All @@ -81,7 +81,7 @@ GENTPROT( normfsc )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* chi, \
double* zeta_r, \
Expand All @@ -94,7 +94,7 @@ GENTPROT( getsc )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
double zeta_r, \
double zeta_i, \
Expand All @@ -107,7 +107,7 @@ GENTPROT( setsc )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* chi, \
obj_t* zeta_r, \
Expand All @@ -120,7 +120,7 @@ GENTPROT( unzipsc )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* zeta_r, \
obj_t* zeta_i, \
Expand All @@ -132,18 +132,18 @@ GENTPROT( zipsc )

// -----------------------------------------------------------------------------

BLIS_EXPORT_BLIS void bli_l0_xsc_check
void bli_l0_xsc_check
(
obj_t* chi
);

BLIS_EXPORT_BLIS void bli_l0_xxsc_check
void bli_l0_xxsc_check
(
obj_t* chi,
obj_t* psi
);

BLIS_EXPORT_BLIS void bli_l0_xx2sc_check
void bli_l0_xx2sc_check
(
obj_t* chi,
obj_t* norm
Expand Down
2 changes: 1 addition & 1 deletion frame/0/bli_l0_fpa.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#define GENPROT( opname ) \
\
PASTECH(opname,_vft) \
BLIS_EXPORT_BLIS BLIS_EXPORT_BLIS PASTEMAC(opname,_qfp)( num_t dt );
PASTEMAC(opname,_qfp)( num_t dt );

GENPROT( absqsc )
GENPROT( normfsc )
Expand Down
34 changes: 17 additions & 17 deletions frame/1/bli_l1v_check.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* x, \
obj_t* y \
Expand All @@ -55,7 +55,7 @@ GENTPROT( swapv )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* x, \
obj_t* index \
Expand All @@ -67,7 +67,7 @@ GENTPROT( amaxv )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* alpha, \
obj_t* x, \
Expand All @@ -81,7 +81,7 @@ GENTPROT( axpbyv )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* alpha, \
obj_t* x, \
Expand All @@ -95,7 +95,7 @@ GENTPROT( scal2v )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* x, \
obj_t* y, \
Expand All @@ -108,7 +108,7 @@ GENTPROT( dotv )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* alpha, \
obj_t* x, \
Expand All @@ -123,7 +123,7 @@ GENTPROT( dotxv )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* x \
);
Expand All @@ -134,7 +134,7 @@ GENTPROT( invertv )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* alpha, \
obj_t* x \
Expand All @@ -147,7 +147,7 @@ GENTPROT( setv )
#undef GENTPROT
#define GENTPROT( opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
void PASTEMAC(opname,_check) \
( \
obj_t* x, \
obj_t* beta, \
Expand All @@ -160,35 +160,35 @@ GENTPROT( xpbyv )

// -----------------------------------------------------------------------------

BLIS_EXPORT_BLIS void bli_l1v_xy_check
void bli_l1v_xy_check
(
obj_t* x,
obj_t* y
);

BLIS_EXPORT_BLIS void bli_l1v_axy_check
void bli_l1v_axy_check
(
obj_t* alpha,
obj_t* x,
obj_t* y
);

BLIS_EXPORT_BLIS void bli_l1v_xby_check
void bli_l1v_xby_check
(
obj_t* x,
obj_t* beta,
obj_t* y
);

BLIS_EXPORT_BLIS void bli_l1v_axby_check
void bli_l1v_axby_check
(
obj_t* alpha,
obj_t* x,
obj_t* beta,
obj_t* y
);

BLIS_EXPORT_BLIS void bli_l1v_dot_check
void bli_l1v_dot_check
(
obj_t* alpha,
obj_t* x,
Expand All @@ -197,18 +197,18 @@ BLIS_EXPORT_BLIS void bli_l1v_dot_check
obj_t* rho
);

BLIS_EXPORT_BLIS void bli_l1v_x_check
void bli_l1v_x_check
(
obj_t* x
);

BLIS_EXPORT_BLIS void bli_l1v_ax_check
void bli_l1v_ax_check
(
obj_t* alpha,
obj_t* x
);

BLIS_EXPORT_BLIS void bli_l1v_xi_check
void bli_l1v_xi_check
(
obj_t* x,
obj_t* index
Expand Down
2 changes: 1 addition & 1 deletion frame/1/bli_l1v_fpa.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#define GENPROT( opname ) \
\
PASTECH2(opname,BLIS_TAPI_EX_SUF,_vft) \
BLIS_EXPORT_BLIS BLIS_EXPORT_BLIS PASTEMAC2(opname,BLIS_TAPI_EX_SUF,_qfp)( num_t dt );
PASTEMAC2(opname,BLIS_TAPI_EX_SUF,_qfp)( num_t dt );

GENPROT( addv )
GENPROT( copyv )
Expand Down
28 changes: 14 additions & 14 deletions frame/1/bli_l1v_ker_prot.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

#define ADDV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
dim_t n, \
Expand All @@ -51,7 +51,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define AMAXV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
dim_t n, \
ctype* restrict x, inc_t incx, \
Expand All @@ -62,7 +62,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define AXPBYV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
dim_t n, \
Expand All @@ -76,7 +76,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define AXPYV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
dim_t n, \
Expand All @@ -89,7 +89,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define COPYV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
dim_t n, \
Expand All @@ -101,7 +101,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define DOTV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
conj_t conjy, \
Expand All @@ -115,7 +115,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define DOTXV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
conj_t conjy, \
Expand All @@ -131,7 +131,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define INVERTV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
dim_t n, \
ctype* restrict x, inc_t incx, \
Expand All @@ -141,7 +141,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define SCALV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjalpha, \
dim_t n, \
Expand All @@ -153,7 +153,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define SCAL2V_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
dim_t n, \
Expand All @@ -166,7 +166,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define SETV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjalpha, \
dim_t n, \
Expand All @@ -178,7 +178,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define SUBV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
dim_t n, \
Expand All @@ -190,7 +190,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define SWAPV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
dim_t n, \
ctype* restrict x, inc_t incx, \
Expand All @@ -201,7 +201,7 @@ BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \

#define XPBYV_KER_PROT( ctype, ch, opname ) \
\
BLIS_EXPORT_BLIS void PASTEMAC(ch,opname) \
void PASTEMAC(ch,opname) \
( \
conj_t conjx, \
dim_t n, \
Expand Down
2 changes: 1 addition & 1 deletion frame/1/other/packv/bli_packv_check.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
*/

BLIS_EXPORT_BLIS void bli_packv_check
void bli_packv_check
(
obj_t* c,
obj_t* p,
Expand Down
2 changes: 1 addition & 1 deletion frame/1/other/packv/bli_packv_cntl.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ typedef struct packv_params_s packv_params_t;

// -----------------------------------------------------------------------------

BLIS_EXPORT_BLIS cntl_t* bli_packv_cntl_obj_create
cntl_t* bli_packv_cntl_obj_create
(
void_fp var_func,
void_fp packv_var_func,
Expand Down
Loading

0 comments on commit e4d07f9

Please sign in to comment.