Export functions without def file (flame#303)

* Revert "restore bli_extern_defs exporting for now"

This reverts commit 09fb07c.

* Remove symbols not intended to be public

* No need of def file anymore

* Fix whitespace

* No need of configure option

* Remove export macro from definitions

* Remove blas export macro from definitions

build/bli_config.h.in

@@ -159,7 +159,23 @@
 #define BLIS_DISABLE_SHARED
 #endif
 
-#define BLIS_EXPORT_BLAS
-#define BLIS_EXPORT_BLIS
+#if !defined(BLIS_ENABLE_SHARED)
+    #define BLIS_EXPORT
+#else
+    #if defined(_WIN32) || defined(__CYGWIN__)
+        #ifdef BLIS_IS_BUILDING_LIBRARY
+            #define BLIS_EXPORT __declspec(dllexport)
+        #else
+            #define BLIS_EXPORT __declspec(dllimport)
+        #endif
+    #elif defined(__GNUC__) && __GNUC__ >= 4
+        #define BLIS_EXPORT __attribute__ ((visibility ("default")))
+    #else
+        #define BLIS_EXPORT
+    #endif
+#endif
+
+#define BLIS_EXPORT_BLIS BLIS_EXPORT
+#define BLIS_EXPORT_BLAS BLIS_EXPORT
 
 #endif

build/libblis-symbols.def

@@ -183,8 +183,6 @@ bli_cgemm4mb
 bli_cgemm4mb_ker_var2
 bli_cgemm4mh
 bli_cgemm_ex
-bli_cgemm_haswell_asm_3x8
-bli_cgemm_haswell_asm_8x3
 bli_cgemm_ker_var2
 bli_cgemm_md_c2r_ref
 bli_cgemmtrsm_l_ukernel
@@ -591,7 +589,6 @@ bli_daddv
 bli_daddv_ex
 bli_damaxv
 bli_damaxv_ex
-bli_damaxv_zen_int
 bli_dasumv
 bli_dasumv_ex
 bli_dasumv_unb_var1
@@ -603,14 +600,11 @@ bli_daxpyd
 bli_daxpyd_ex
 bli_daxpyf
 bli_daxpyf_ex
-bli_daxpyf_zen_int_8
 bli_daxpym
 bli_daxpym_ex
 bli_daxpym_unb_var1
 bli_daxpyv
 bli_daxpyv_ex
-bli_daxpyv_zen_int
-bli_daxpyv_zen_int10
 bli_dccastm
 bli_dccastnzm
 bli_dccastv
@@ -640,16 +634,12 @@ bli_ddotaxpyv
 bli_ddotaxpyv_ex
 bli_ddotv
 bli_ddotv_ex
-bli_ddotv_zen_int
-bli_ddotv_zen_int10
 bli_ddotxaxpyf
 bli_ddotxaxpyf_ex
 bli_ddotxf
 bli_ddotxf_ex
-bli_ddotxf_zen_int_8
 bli_ddotxv
 bli_ddotxv_ex
-bli_ddotxv_zen_int
 bli_ddpackm_blk_var1_md
 bli_ddpackm_cxk_1e_md
 bli_ddpackm_cxk_1r_md
@@ -673,12 +663,8 @@ bli_dgemm4mb
 bli_dgemm4mb_ker_var2
 bli_dgemm4mh
 bli_dgemm_ex
-bli_dgemm_haswell_asm_6x8
-bli_dgemm_haswell_asm_8x6
 bli_dgemm_ker_var2
-bli_dgemmtrsm_l_haswell_asm_6x8
 bli_dgemmtrsm_l_ukernel
-bli_dgemmtrsm_u_haswell_asm_6x8
 bli_dgemmtrsm_u_ukernel
 bli_dgemm_ukernel
 bli_dgemv
@@ -746,11 +732,6 @@ bli_dinvertv_ex
 bli_divsc
 bli_divsc_check
 bli_divsc_qfp
-bli_dlamc1
-bli_dlamc2
-bli_dlamc3
-bli_dlamc4
-bli_dlamc5
 bli_dlamch
 bli_dmachval
 bli_dmkherm
@@ -838,8 +819,6 @@ bli_dscalm_ex
 bli_dscalm_unb_var1
 bli_dscalv
 bli_dscalv_ex
-bli_dscalv_zen_int
-bli_dscalv_zen_int10
 bli_dscastm
 bli_dscastnzm
 bli_dscastv
@@ -1452,8 +1431,6 @@ bli_pool_init
 bli_pool_print
 bli_pool_reinit
 bli_pool_shrink
-bli_pow_di
-bli_pow_ri
 bli_prime_factorization
 bli_printm
 bli_printm_ex
@@ -1510,7 +1487,6 @@ bli_saddv
 bli_saddv_ex
 bli_samaxv
 bli_samaxv_ex
-bli_samaxv_zen_int
 bli_sasumv
 bli_sasumv_ex
 bli_sasumv_unb_var1
@@ -1522,14 +1498,11 @@ bli_saxpyd
 bli_saxpyd_ex
 bli_saxpyf
 bli_saxpyf_ex
-bli_saxpyf_zen_int_8
 bli_saxpym
 bli_saxpym_ex
 bli_saxpym_unb_var1
 bli_saxpyv
 bli_saxpyv_ex
-bli_saxpyv_zen_int
-bli_saxpyv_zen_int10
 bli_sba_acquire
 bli_sba_checkin_array
 bli_sba_checkout_array
@@ -1591,16 +1564,12 @@ bli_sdotaxpyv
 bli_sdotaxpyv_ex
 bli_sdotv
 bli_sdotv_ex
-bli_sdotv_zen_int
-bli_sdotv_zen_int10
 bli_sdotxaxpyf
 bli_sdotxaxpyf_ex
 bli_sdotxf
 bli_sdotxf_ex
-bli_sdotxf_zen_int_8
 bli_sdotxv
 bli_sdotxv_ex
-bli_sdotxv_zen_int
 bli_sdpackm_blk_var1_md
 bli_sdpackm_cxk_1e_md
 bli_sdpackm_cxk_1r_md
@@ -1643,12 +1612,8 @@ bli_sgemm4mb
 bli_sgemm4mb_ker_var2
 bli_sgemm4mh
 bli_sgemm_ex
-bli_sgemm_haswell_asm_16x6
-bli_sgemm_haswell_asm_6x16
 bli_sgemm_ker_var2
-bli_sgemmtrsm_l_haswell_asm_6x16
 bli_sgemmtrsm_l_ukernel
-bli_sgemmtrsm_u_haswell_asm_6x16
 bli_sgemmtrsm_u_ukernel
 bli_sgemm_ukernel
 bli_sgemv
@@ -1717,11 +1682,6 @@ bli_sinvertd_ex
 bli_sinvertsc
 bli_sinvertv
 bli_sinvertv_ex
-bli_slamc1
-bli_slamc2
-bli_slamc3
-bli_slamc4
-bli_slamc5
 bli_slamch
 bli_sleep
 bli_smachval
@@ -1793,8 +1753,6 @@ bli_sscalm_ex
 bli_sscalm_unb_var1
 bli_sscalv
 bli_sscalv_ex
-bli_sscalv_zen_int
-bli_sscalv_zen_int10
 bli_sscastm
 bli_sscastnzm
 bli_sscastv
@@ -2245,8 +2203,6 @@ bli_zgemm4mb
 bli_zgemm4mb_ker_var2
 bli_zgemm4mh
 bli_zgemm_ex
-bli_zgemm_haswell_asm_3x4
-bli_zgemm_haswell_asm_4x3
 bli_zgemm_ker_var2
 bli_zgemm_md_c2r_ref
 bli_zgemmtrsm_l_ukernel
@@ -2528,19 +2484,6 @@ bli_zzpackm_struc_cxk_md
 bli_zzxpbym_md
 bli_zzxpbym_md_ex
 bli_zzxpbym_md_unb_var1
-bla_c_abs
-bla_c_div
-bla_d_abs
-bla_d_cnjg
-bla_d_imag
-bla_d_sign
-bla_f__cabs
-bla_r_abs
-bla_r_cnjg
-bla_r_imag
-bla_r_sign
-bla_z_abs
-bla_z_div
 sasum_
 sasumsub_
 saxpy_

common.mk

@@ -506,9 +506,9 @@ SOFLAGS    := -shared
 ifeq ($(IS_WIN),yes)
 # Windows shared library link flags.
 ifeq ($(CC_VENDOR),clang)
-SOFLAGS    += -Wl,-def:build/libblis-symbols.def -Wl,-implib:$(BASE_LIB_PATH)/$(LIBBLIS).lib
+SOFLAGS    += -Wl,-implib:$(BASE_LIB_PATH)/$(LIBBLIS).lib
 else
-SOFLAGS    += -Wl,--export-all-symbols -Wl,--out-implib,$(BASE_LIB_PATH)/$(LIBBLIS).dll.a
+SOFLAGS    += -Wl,--out-implib,$(BASE_LIB_PATH)/$(LIBBLIS).dll.a
 endif
 else
 # Linux shared library link flags.

frame/0/bli_l0_check.c

@@ -41,7 +41,7 @@
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
+void PASTEMAC(opname,_check) \
      ( \
        obj_t*  chi, \
        obj_t*  psi  \
@@ -61,7 +61,7 @@ GENFRONT( subsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
+void PASTEMAC(opname,_check) \
      ( \
        obj_t*  chi  \
      ) \
@@ -75,7 +75,7 @@ GENFRONT( invertsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
+void PASTEMAC(opname,_check) \
      ( \
        obj_t*  chi, \
        obj_t*  norm  \

frame/0/bli_l0_oapi.c

@@ -41,7 +41,7 @@
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        obj_t*  chi, \
        obj_t*  absq  \
@@ -81,7 +81,7 @@ GENFRONT( normfsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        obj_t*  chi, \
        obj_t*  psi  \
@@ -120,7 +120,7 @@ GENFRONT( subsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        obj_t*  chi  \
      ) \
@@ -153,7 +153,7 @@ GENFRONT( invertsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        obj_t*  chi, \
        obj_t*  psi  \
@@ -186,7 +186,7 @@ GENFRONT( sqrtsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        obj_t*  chi, \
        double* zeta_r, \
@@ -230,7 +230,7 @@ GENFRONT( getsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        double  zeta_r, \
        double  zeta_i, \
@@ -264,7 +264,7 @@ GENFRONT( setsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        obj_t*  chi, \
        obj_t*  zeta_r, \
@@ -307,7 +307,7 @@ GENFRONT( unzipsc )
 #undef  GENFRONT
 #define GENFRONT( opname ) \
 \
-BLIS_EXPORT_BLIS void PASTEMAC0(opname) \
+void PASTEMAC0(opname) \
      ( \
        obj_t*  zeta_r, \
        obj_t*  zeta_i, \