ADO-2646 - FontAwesome 5 Pro #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessedoyle
force-pushed
the
ado-2646
branch
2 times, most recently
from
ba3b255
to
82dd873
Compare
* We are looking to use pro-only FontAwesome 5 icons in an upcoming feature. We have a perpetual enterprise license for FontAwesome Pro, but we are forbidden from distributing the webfont files to "non-creators" in the license. * Uploading the webfont files to this open-source package is considered a breach of the pro license (according to fontawesome support), so we need to create conditions to "enable" the pro icon set specifically for our organization's use. * Symlink in the pro fontawesome files into 'vendor/assets/fonts/font-awesome` when the configuration value of `font_awesome_pro_source_path` is provided. * Because the files are symlinked into the vendored asset directory, they override the free files provided by the `font-awesome-sass` gem [1] in the asset pipeline. * The `font-awesome-sass` gem does not provide unicode mappings for the pro-only icons. If we wish to use them, we need to define the unicode mapping in the `font_awesome_pro.scss` file. [1]: FortAwesome/font-awesome-sass#146 (comment) SEE: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/2646
added 2 commits
September 5, 2019 16:08
* Fix stylelint errors so CI passes. SEE: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/2646
* Allow button grouping elements to expand to the full height if possible. SEE: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/2646
|
We're closing this now as we don't want the additional complexity to conform to the pro license. We're just going to use the free icons for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upcoming feature. We have a perpetual enterprise license
for FontAwesome Pro, but we are forbidden from distributing
the webfont files to "non-creators" in the license.
is considered a breach of the pro license (according to
fontawesome support), so we need to create conditions
to "enable" the pro icon set specifically for our
organization's use.
'vendor/assets/fonts/font-awesome
when the configuration value offont_awesome_pro_source_path` is provided.directory, they override the free files provided by
the
font-awesome-sassgem 1 in the asset pipeline.font-awesome-sassgem does not provide unicodemappings for the pro-only icons. If we wish to use
them, we need to define the unicode mapping in
the
font_awesome_pro.scssfile.SEE: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/264