Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed value check in json_object_set_value #1015

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

Th3-822
Copy link
Contributor

@Th3-822 Th3-822 commented Nov 26, 2021

Regression from #983

Code was only allowing json objects to be passed as arguments

@UnrealKaraulov
Copy link
Contributor

UnrealKaraulov commented Dec 1, 2021

@Th3-822 thanks!

But why this pull request is not merged?(

@UnrealKaraulov
Copy link
Contributor

UnrealKaraulov commented Dec 3, 2021

@dvander Please merge it?? This is critical issue. I can't use this native because it really broken...

@dvander dvander merged commit e8909c1 into alliedmodders:master Dec 3, 2021
@Th3-822 Th3-822 deleted the fix-json_object_set_value branch December 3, 2021 03:33
@Th3-822
Copy link
Contributor Author

Th3-822 commented Dec 3, 2021

btw, it's in 1.9 too

@UnrealKaraulov
Copy link
Contributor

@Th3-822 in 1.9 it no has value check, and not broken

@Th3-822
Copy link
Contributor Author

Th3-822 commented Dec 3, 2021

it is @ bb4b818
image

@UnrealKaraulov
Copy link
Contributor

UnrealKaraulov commented Dec 3, 2021

@Th3-822 yes, really :(

Th3-822 added a commit to Th3-822/amxmodx that referenced this pull request Dec 3, 2021
dvander pushed a commit that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants