Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Sentinel support feign ? #6

Closed
xiejiashuai opened this issue Sep 6, 2018 · 3 comments
Closed

Can Sentinel support feign ? #6

xiejiashuai opened this issue Sep 6, 2018 · 3 comments
Assignees
Labels
area/sentinel spring cloud alibaba sentinel kind/enhancement
Milestone

Comments

@xiejiashuai
Copy link
Contributor

RestTemplate 使用起来太不友好了,不如Feign方便。可否考虑支持下Feign。

Spring Framework RestTemplate is not convenient when used , can consider supproting Feign.

@flystar32
Copy link
Member

Sentinel 目前对于有线程切换的行为处理还不大完善,待 Sentinel 完善支持后会评估支持方案。

Sentinel currently does not have a good deal of behavior for thread switching, we will evaluate it after Sentinel supports this scenario.

flystar32 pushed a commit that referenced this issue Nov 5, 2018
@fangjian0423 fangjian0423 added this to the 0.2.1 milestone Dec 3, 2018
@fangjian0423 fangjian0423 self-assigned this Dec 3, 2018
@fangjian0423
Copy link
Contributor

A simple FeignClient like this:

@FeignClient(name = "service-provider", fallback = EchoServiceFallback.class)
public interface EchoService {
	@RequestMapping(value = "/echo/{str}", method = RequestMethod.GET)
	String echo(@PathVariable("str") String str);
}

The resource name of method echo is: GET:http://service-provider/echo/{str} and we use SphU to handle it:

Entry entry = SphU.entry(resourceName, EntryType.OUT, 1, args);

So we can use any rules, including ParamFlowRule.

@zjun2
Copy link

zjun2 commented Jan 30, 2019

心累。。。一群中国人用英文沟通。我们这种菜鸟英文不好,看起来真心心累🤨

@fangjian0423 fangjian0423 added the area/sentinel spring cloud alibaba sentinel label Mar 17, 2019
@fangjian0423 fangjian0423 changed the title Can Supprot Feign ? Can Sentinel support feign ? Mar 17, 2019
flystar32 pushed a commit that referenced this issue Apr 26, 2019
fangjian0423 pushed a commit that referenced this issue Jan 20, 2020
mercyblitz pushed a commit that referenced this issue Sep 17, 2020
theonefx pushed a commit to theonefx/spring-cloud-alibaba that referenced this issue Aug 2, 2021
theonefx pushed a commit to theonefx/spring-cloud-alibaba that referenced this issue Aug 2, 2021
theonefx pushed a commit to theonefx/spring-cloud-alibaba that referenced this issue Aug 2, 2021
theonefx pushed a commit to theonefx/spring-cloud-alibaba that referenced this issue Aug 2, 2021
theonefx pushed a commit to theonefx/spring-cloud-alibaba that referenced this issue Aug 2, 2021
yuluo-yx referenced this issue in yuluo-yx/spring-cloud-alibaba Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sentinel spring cloud alibaba sentinel kind/enhancement
Projects
None yet
Development

No branches or pull requests

4 participants