feature: Expand ai-statistics plugins to enhance tracing capacity #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…值源（如请求头、响应头、属性等）来设置追踪标签。此外，实现了在请求处理流程中获取请求头和响应头值，并将这些值作为标签发送给追踪系统。 主要变更： - 扩展AIStatisticsConfig结构体，新增TracingLabel数组用于配置追踪标签。 - 新增onHttpRequestHeaders和onHttpResponseHeaders函数，用于处理请求和响应头的追踪标签设置。 -调整parseConfig函数以解析并存储TracingLabel配置。 - 实现fetchTracingLabelValue函数，用于根据配置的标签值源获取相应的值，并设置追踪标签。 此更新使得可以根据请求和响应头的值动态设置追踪标签，增强追踪数据的可关联性和信息丰富度。
shalldid
changed the title
johnlanni
requested changes
Aug 25, 2024
| config.Enable = configJson.Get("enable").Bool() | ||
|
|
||
| // Parse tracing label. | ||
| traceLabelConfigArray := configJson.Get("tracing_label").Array() |
| ValueSource: traceLabel.Get("value_source").String(), | ||
| Value: traceLabel.Get("value").String(), | ||
| } | ||
| config.TracingLabel[traceLabel.ValueSource] = traceLabel |
There was a problem hiding this comment.
一种source类型应该支持多对kv，这里为什么设计成一种类型只能有一对kv呢
There was a problem hiding this comment.
这里是个数组，我们设计的是配置可以是如下格式的，不是最顶层用 source 分类：
- key: "input_tokens"
value_source: "property"
value: "input_tokens" - key: "output_tokens"
value_source: "property"
value: "output_tokens"
There was a problem hiding this comment.
@johnlanni 这种方式也可以实现一种source类型支持多对kv
|
|
||
| // sets the input_tokens and output_tokens tags in the tracing span. | ||
| func setTracingTokenCostTag(config AIStatisticsConfig, inputToken int64, outputToken int64, log wrapper.Log) { | ||
| fetchTracingLabelValue(config, "input_tokens", nil, fmt.Sprintf("%d", inputToken), log) |
There was a problem hiding this comment.
input token和output token不应该是属于property类型么
| endTime, _ := strconv.ParseInt(endTimeStr, 10, 64) | ||
| totalTime := endTime - startTime | ||
|
|
||
| fetchTracingLabelValue(config, "total_time", nil, fmt.Sprintf("%d", totalTime), log) |
There was a problem hiding this comment.
total time不是一种value source，复用这个函数显得很奇怪
| ctx.DontReadResponseBody() | ||
| return types.ActionContinue | ||
| } | ||
| contentType, _ := proxywasm.GetHttpResponseHeader("content-type") | ||
| if !strings.Contains(contentType, "text/event-stream") { | ||
| ctx.BufferResponseBody() | ||
| } | ||
|
|
||
| // calculate total cost time and set tracing span tag. | ||
| startTimeStr, _ := proxywasm.GetHttpResponseHeader("req-arrive-time") |
There was a problem hiding this comment.
不要依赖这这个特定的header来解析时间，因为这几个header是higress特有的，这个插件应该可以比较通用才对。
在 onHttpRequestHeader阶段记个时间，在onHttpStreamingBody的第一个chunk和最后一个chunk分别记个时间，就可以得到首token响应时间和完整响应时间了
1.优化自定义统计配置字段，trace_label->trace_span 2.耗时统计方法优化，移除httpResponseHeader 头定义依赖，自定义context属性实现耗时计算 3.优化代码结构
|
@johnlanni 已按照建议修改提交 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 35.91% 44.32% +8.41%
==========================================
Files 69 75 +6
Lines 11576 9821 -1755
==========================================
+ Hits 4157 4353 +196
+ Misses 7104 5140 -1964
- Partials 315 328 +13 |
johnlanni
requested changes
Aug 27, 2024
1.修改README.md 2.修复setTracingSpanValueBySource()对入参tracingSource与tracingSpanEle.ValueSource未进行校验的问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
扩展统计插件，增加tracing能力，可根据配置文件动态设置追踪标签，增强追踪数据的可关联性和信息丰富度。
Ⅱ. Does this pull request fix one issue?
fixes #1234
Ⅲ. Special notes for reviews
主要变更：