Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ai敏感词拦截插件 #1190

Merged
merged 28 commits into from
Aug 16, 2024
Merged

feat: ai敏感词拦截插件 #1190

merged 28 commits into from
Aug 16, 2024

Conversation

007gzs
Copy link
Collaborator

@007gzs 007gzs commented Aug 8, 2024

Ⅰ. Describe what this PR did

ai敏感词拦截插件

Ⅱ. Does this pull request fix one issue?

fixes #1182
fixes #1140

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.87%. Comparing base (ef31e09) to head (2b50617).
Report is 46 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
- Coverage   35.91%   35.87%   -0.04%     
==========================================
  Files          69       69              
  Lines       11576     9500    -2076     
==========================================
- Hits         4157     3408     -749     
+ Misses       7104     5775    -1329     
- Partials      315      317       +2     

see 67 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦再补一个e2e测试用例,可以用custom-response插件来自定义响应,来验证响应的masking效果

@007gzs
Copy link
Collaborator Author

007gzs commented Aug 15, 2024

麻烦再补一个e2e测试用例,可以用custom-response插件来自定义响应,来验证响应的masking效果

done

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@johnlanni johnlanni merged commit 25b085c into alibaba:main Aug 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ai敏感词拦截插件 Add code lint for rust plugin code
3 participants