Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP: user ID for containers from environment #2825

Merged
merged 2 commits into from
Feb 7, 2022
Merged

FTP: user ID for containers from environment #2825

merged 2 commits into from
Feb 7, 2022

Conversation

ennru
Copy link
Member

@ennru ennru commented Feb 7, 2022

Commit 1:

  • Upgrade docker compose file version
  • Shell script to start FTP containers (didn't get default values to work locally)

Refs #1810 and #2816

Commit 2:

  • Remove remaining Travis references

@ennru ennru added the p:ftp label Feb 7, 2022
@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. documentation labels Feb 7, 2022
@ennru ennru marked this pull request as ready for review February 7, 2022 13:56
@ennru ennru merged commit 2f3bb8d into master Feb 7, 2022
@ennru ennru deleted the ennru-ftp branch February 7, 2022 14:48
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it only works accidentally because UIDs are numerical and the local user might have a standard UID that may by accident also be present in the container?

@ennru
Copy link
Member Author

ennru commented Feb 7, 2022

I wonder if it only works accidentally because UIDs are numerical and the local user might have a standard UID that may by accident also be present in the container?

That was exactly what broke it. It had hardcoded ids that worked on Travis, but not on GitHub CI. In #1810 users reported similar issues with running the FTP tests locally.

This was referenced Feb 7, 2022
@jrudolph
Copy link
Member

jrudolph commented Feb 7, 2022

I wonder if it only works accidentally because UIDs are numerical and the local user might have a standard UID that may by accident also be present in the container?

That was exactly what broke it. It had hardcoded ids that worked on Travis, but not on GitHub CI. In #1810 users reported similar issues with running the FTP tests locally.

Ah I see. Didn't get before that you had to access those files from outside the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. documentation p:ftp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants