added shortcuts '+', '-' and 'o', underlining for those and 'e' #26
Conversation
app/task_detail.go
Outdated
| case 'o': | ||
| td.setTaskDate(parseDateInputOrCurrent("").Unix(), true) | ||
| return nil | ||
| case '+': | ||
| td.setTaskDate(parseDateInputOrCurrent(td.taskDate.GetText()).AddDate(0, 0, 1).Unix(), true) | ||
| return nil | ||
| case '-': | ||
| td.setTaskDate(parseDateInputOrCurrent(td.taskDate.GetText()).AddDate(0, 0, -1).Unix(), true) |
There was a problem hiding this comment.
Just a quick idea, can we reuse previously defined todaySelector(), prevDaySelector(), nextDaySelector() methods here?
There was a problem hiding this comment.
I have no idea to be honest, my experience with Go pretty much non existent. But I guess it works, otherwise you probably wouldn't have suggested it 😉
I'll check out the tutorials and see if I can figure it out 🙂
There was a problem hiding this comment.
Maybe I can assist. You need to do a few changes:
- Remove
todaySelector(),prevDaySelector(),nextDaySelector()functions from insidemakeDateRow()
- Now, at the end of file, define them as methods of
TaskDetailPane
- In
makeDateRow(), use these methods
- Use the same methods in shortcut switch-case
Then compile and test, hope it'll work. :)
The only thing we're achieving by these changes is - avoiding duplication of the same logic in several places.
There was a problem hiding this comment.
Ah ok, got it, thanks for the explanation! I thought there might be some magic possibility to basically call function within functions in Go 😄
I've implemented the changes, build went well and buttons as well as the shortcuts work as expected, see commit 3af36bd.
|
Hi @sdrwtf, Merged with many many thanks 😊 |
Info
I've tested the changes on Ubuntu 20.04 without any issues but please be aware that this is the first time I do something in Go, so please double-check if the changes are alright 😉
PR fixes #20
Changes
Added shortcuts:
ofor set due date to today+for due date plus 1 day-for due date minus 1 dayMarked shortcuts by underlining for the above and and
einedit.Added new shortcuts to the README.