Skip to content

Commit

Permalink
Expand assert in LightProcess::proc_open
Browse files Browse the repository at this point in the history
Summary: This is occasionally firing in prod. There haven't been any useful
core files but this might give us a hint as to what's going wrong.

Reviewed By: @ptarjan

Differential Revision: D1577087
  • Loading branch information
swtaarrs authored and hhvm-bot committed Sep 25, 2014
1 parent 43c17b2 commit 59e9b71
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion hphp/util/light-process.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,8 @@ pid_t LightProcess::proc_open(const char *cmd, const std::vector<int> &created,
}
return -1;
}
always_assert(buf == "success");
always_assert_flog(buf == "success",
"Unexpected message from light process: `{}'", buf);
int64_t pid = -1;
lwp_read_int64(fin, pid);
always_assert(pid);
Expand Down

0 comments on commit 59e9b71

Please sign in to comment.