Skip to content

Commit

Permalink
Revert reentry stress tests next - again (microsoft#13710)
Browse files Browse the repository at this point in the history
_The fix in next was overwritten by an integration from main_

Original PR: microsoft#13620

OP Reentry in the stress tests is still causing test incidents in next due to the lifecycle of the container. This requires more refactoring of the stress tests. Until then, these configs should be decoupled and the reentry feature disabled in the stress tests in order to continue having test coverage for compression.
  • Loading branch information
andre4i committed Jan 20, 2023
1 parent 067332d commit 8b763d8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 15 deletions.
17 changes: 3 additions & 14 deletions packages/test/test-service-load/src/loadTestDataStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,8 @@ export class LoadTestDataStoreModel {
this.partnerId = (this.config.runId + halfClients) % this.config.testConfig.numClients;
const changed = (taskId) => {
if (taskId === this.taskId && this.taskStartTime !== 0) {
Promise.resolve().then(() => {
this.dir.set(taskTimeKey, this.totalTaskTime);
this.taskStartTime = 0;
}).catch((error) => {
this.logger.sendErrorEvent({
eventName: "TaskManager_OnValueChanged",
}, error);
});
this.dir.set(taskTimeKey, this.totalTaskTime);
this.taskStartTime = 0;
}
};
this.taskManager.on("lost", changed);
Expand Down Expand Up @@ -262,12 +256,7 @@ export class LoadTestDataStoreModel {
: Math.trunc(value * blobsPerOp - this.blobCount);

if (newBlobs > 0) {
Promise.resolve().then(() => {
this.blobUploads.push(...[...Array(newBlobs)].map(async () => this.writeBlob(this.blobCount++)));
}).catch((error) => this.logger.sendErrorEvent({
eventName: "WriteBlobFailed_OnCounterValueChanged",
count: this.blobCount,
}, error));
this.blobUploads.push(...[...Array(newBlobs)].map(async () => this.writeBlob(this.blobCount++)));
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/test/test-service-load/src/optionsMatrix.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export function generateRuntimeOptions(
flushMode: [undefined],
compressionOptions: [{ minimumBatchSizeInBytes: 500, compressionAlgorithm: CompressionAlgorithms.lz4 }],
maxBatchSizeInBytes: [undefined],
enableOpReentryCheck: [true],
enableOpReentryCheck: [undefined],
chunkSizeInBytes: [undefined],
};

Expand Down

0 comments on commit 8b763d8

Please sign in to comment.