Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP] Remove old benchmarking classes #2082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MatthewMiddlehurst
Copy link
Member

This PR removes the BaseBenchmark class. I believe this was primarily for forecasting, but I have not seen it used. I do not think we need a class based structure like this in benchmarking. With this removed there are no usages of kotsu so this has been taken out of all_extras also.

get_qalpha only has one usage, so I have moved it to performance_metrics and made it private.

@MatthewMiddlehurst MatthewMiddlehurst added benchmarking Benchmarking package deprecation This issue is related to deprecation or removal of code labels Sep 20, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#264F59}{\textsf{benchmarking}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarking Benchmarking package deprecation This issue is related to deprecation or removal of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant