[DEP] Remove old benchmarking classes #2082
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
BaseBenchmark
class. I believe this was primarily for forecasting, but I have not seen it used. I do not think we need a class based structure like this inbenchmarking
. With this removed there are no usages ofkotsu
so this has been taken out ofall_extras
also.get_qalpha
only has one usage, so I have moved it toperformance_metrics
and made it private.