Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify browser support and add issue severity classification #4662

Merged
merged 6 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
docs: clarify browser support and add issue severity classification
  • Loading branch information
rubencarvalho committed Aug 8, 2024
commit 4d3d677e8e8a41e66d705c69b251747e44223e53
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,17 @@ body:
id: code
attributes:
label: Sample code that illustrates the problem
- type: dropdown
id: severity
attributes:
label: Severity
description: Please select the severity level of this issue. For more details, refer to our [documentation](https://github.com/adobe/spectrum-web-components/blob/main/CONTRIBUTING.md#issue-severity-classification)
options:
- SEV 1
- SEV 2
- SEV 3
- SEV 4
- SEV 5
- type: textarea
id: logs
attributes:
Expand Down
32 changes: 32 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,21 @@ Create an issue on the repository and provide the following information by filli
- What you would expect to happen
- What actually happens
- Notes (for example why you think this might be happening, or stuff you tried that didn't work)
- Issue severity

### Issue severity classification

Providing the correct issue severity classification allows us to more adequately assess and prioritize your issue.
rubencarvalho marked this conversation as resolved.
Show resolved Hide resolved

Please be aware of our issue severity classification criteria:

| Severity level | Description | Examples |
| -------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| **SEV 1** | A critical design or functionality issue that breaks the design system, causes significant usability problems, or exposes critical security vulnerabilities. This issue impacts all users and/or essential workflows, making users unwilling or unable to complete any tasks. Requires immediate attention. | Broken navigation system, complete unresponsiveness on all devices, components not rendering, inaccessible primary actions, security vulnerabilities. Accessibility: The end user is not able to access the product or complete core user tasks or activities (key navigational elements not accessible via keyboard, missing or incorrect form labels that prevent screen reader users from completing forms or actions, critical color contrast issues that prevent users from reading or interacting with essential content). |
rubencarvalho marked this conversation as resolved.
Show resolved Hide resolved
| **SEV 2** | A significant problem affecting the design, usability or functionality of the system or components for a subset of users. These issues cause major disruptions and prevent users from completing tasks or workflows. Accessibility: Does not conform with WCAG 2.1 Level AA criteria and blocks core user tasks (no known workaround). | Content that is out of view or unreachable by customers, critical buttons or links not functioning or actions that cannot be submitted. Unintentional breaking changes causing disruptions in production environments. Accessibility: Issue with a component or controller with widespread use and blocks core user tasks (no known workaround). |
rubencarvalho marked this conversation as resolved.
Show resolved Hide resolved
| **SEV 3** | A design or functionality issue that causes noticeable errors or minor usability problems for users. These defects cause confusion or degrade user experience but do not prevent task completion. Accessibility: Does not conform with WCAG 2.1 Level AA criteria and is either non-blocking for core user tasks or blocking for non-core user tasks. | Misleading labels, inconsistent component behavior, unexpected interactions, decreases in system performance. Accessibility: Workarounds are available and discoverable for the end user to complete core user tasks, or the end user is not able to complete non-core user tasks (inadequate ARIA labels, improper focus management, insufficient color contrast for non-critical elements). |
rubencarvalho marked this conversation as resolved.
Show resolved Hide resolved
| **SEV 4** | A minor design flaw that affects user experience but doesn't have a serious impact on overall usability or functionality. These issues do not prevent users from completing tasks. Accessibility: Does not conform with WCAG 2.1 Level AA criteria but has lower user impact. | Minor visual inconsistencies, non-critical content misalignment, or minor layout issues. Accessibility: A WCAG violation is present in areas not frequently visited by end users or has a lower impact on overall accessibility and usability. |
rubencarvalho marked this conversation as resolved.
Show resolved Hide resolved
| **SEV 5** | A low-level design inconsistency or minor issue that slightly affects usability or aesthetic, with minimal impact on users. | Slight color deviations, minor typographical errors, or small spacing inconsistencies that do not impact functionality. |

## Do you intend to add a new feature or change an existing one?

Expand Down Expand Up @@ -92,6 +107,23 @@ type(scope?): subject #scope is optional, but should reference the package you a

We maintain a specific standard of commit messages while committing to the respository. See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/#summary)

## Browsers support
rubencarvalho marked this conversation as resolved.
Show resolved Hide resolved

When contributing to our system, please consider the target browsers we support.
rubencarvalho marked this conversation as resolved.
Show resolved Hide resolved

We support the latest 2 major versions of these browsers for desktop:

- Google Chrome
- Mozilla Firefox
- Microsoft Edge
- Apple Safari for macOS

We do not support Microsoft Internet Explorer.

We support all viewport sizes across supported desktop browsers.

While our components are designed to be responsive and mobile-friendly, we do not yet fully support mobile browsers due to limited testing in mobile hardware. We encourage contributors to keep mobile compatibility in mind and to test updates on mobile devices when possible.

## Do you want to contribute to the Spectrum Web Components documentation?

Please read [Contributing Guidelines for documentation](https://github.com/adobe/spectrum-web-components#documentation)
Expand Down
10 changes: 8 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@ To this end, Spectrum Web Components only targets _modern_, evergreen browsers t

- NodeJS >= 18.17.0
- Typescript
- Browsers with Custom Elements V1 and Shadow DOM support, e.g. Chrome, Firefox, Safari, Edge (79+)
- Or appropriate [polyfills](https://github.com/webcomponents/webcomponentsjs) in older browsers.
- Supported desktop browsers:
- Last 2 versions of Chrome
- Last 2 versions of Firefox
- Last 2 versions of Safari
- Last 2 versions of Edge
- Or appropriate [polyfills](https://github.com/webcomponents/webcomponentsjs) in older browsers.
- We support all viewport sizes across supported desktop browsers.
- While our components are designed to be responsive and mobile-friendly, we do not yet fully support mobile browsers due to limited testing in mobile hardware. We advise testing updates on mobile devices before updating and are happy to address any reported issues.

# Getting started

Expand Down
Loading