Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(statuslight)!: migrate statuslight to core tokens #1495

Merged
merged 21 commits into from
Sep 21, 2022
Merged

feat(statuslight)!: migrate statuslight to core tokens #1495

merged 21 commits into from
Sep 21, 2022

Conversation

yosevu
Copy link
Contributor

@yosevu yosevu commented Aug 9, 2022 •
edited
Loading

Description

  • Move skin.css styles to index.css
  • Update windows high contrast mode styles
  • Update semantic and non-semantic color examples to align with batch 2 XD file
  • Remove deprecated colors
  • Remove disabled state based on note in batch 2 XD file

How and where has this been tested?

  • Tested locally referencing the Progress-bar XD file.
  • Tested WHCM with forced colors in Chrome Emulation

Screenshots

Screen Shot 2022-08-10 at 8 01 29 AM

Screen Shot 2022-08-10 at 8 00 57 AM

Screen Shot 2022-08-10 at 8 00 47 AM

Screen Shot 2022-08-10 at 8 00 34 AM

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • This pull request is ready to merge.

@yosevu yosevu changed the title Yosevu/css 115 migrate statuslight to core tokens feat(statuslight)!: migrate statuslight to core tokens Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022 •
edited
Loading

🚀 Deployed on https://pr-1495--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 9, 2022 23:01 Inactive
@yosevu yosevu marked this pull request as ready for review August 9, 2022 23:05
@bernhard-adobe bernhard-adobe self-requested a review August 10, 2022 03:33
bernhard-adobe
bernhard-adobe reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@bernhard-adobe bernhard-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to remove some of those log files and the local lint-settings.
Also do we maybe miss a high-contrast mode here for the Status-lights?

Otherwise great work!

.log/ti-56041.log Outdated
@@ -0,0 +1,139 @@
[06:01:02.264] Global cache location '/Users/yosevu/Library/Caches/typescript/4.7', safe file path '/users/yosevu/.nvm/versions/node/v14.17.0/lib/node_modules/typescript/lib/typingsafelist.json', types map path /users/yosevu/.nvm/versions/node/v14.17.0/lib/node_modules/typescript/lib/typesmap.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove these log-files from being added to the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't realize I committed them.

.stylelintrc.yml Outdated
@@ -0,0 +1,21 @@
extends: stylelint-config-standard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should maybe added to the local .stylelintrc file on your computer and maybe not to the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. I added this accidentally with the my .log

components/statuslight/index.css
.spectrum-StatusLight {
/* Static tokens */
--spectrum-statuslight-corner-radius: 50%;
--spectrum-statuslight-font-weight: 400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could use here for now something like --spectrum-font-weight-regular: 400; https://github.com/adobe/spectrum-css/blob/main/components/tokens/custom-spectrum/custom-vars.css#L32

@yosevu yosevu force-pushed the yosevu/css-115-migrate-statuslight-to-core-tokens branch from 50ed022 to a073ba1 Compare August 10, 2022 13:24
@github-actions github-actions bot temporarily deployed to pull request August 10, 2022 13:29 Inactive
@bernhard-adobe
Copy link
Contributor

VRT test is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/29/

@github-actions github-actions bot temporarily deployed to pull request August 15, 2022 13:26 Inactive
pfulton
pfulton approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @yosevu - thanks for your work on this.

components/statuslight/index.css Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 16, 2022 20:08 Inactive
@pfulton
Copy link
Collaborator

pfulton commented Aug 16, 2022

Released:
@spectrum-css/statuslight@5.0.0-beta.0

@pfulton pfulton added the released-beta Indicates a beta release has been rolled for this PR label Aug 16, 2022
@pfulton
Copy link
Collaborator

pfulton commented Aug 26, 2022

@yosevu - there was a core tokens release that will affect the colors for StatusLight. The CSS tokens package for those changes will be in: - @spectrum-css/tokens@1.0.7.

There's also a Jira ticket about this: https://jira.corp.adobe.com/browse/CSS-240

@yosevu yosevu force-pushed the yosevu/css-115-migrate-statuslight-to-core-tokens branch from 23d4f4c to f2b9497 Compare August 29, 2022 09:35
@github-actions github-actions bot temporarily deployed to pull request August 29, 2022 09:39 Inactive
@yosevu
Copy link
Contributor Author

yosevu commented Aug 29, 2022

@yosevu - there was a core tokens release that will affect the colors for StatusLight. The CSS tokens package for those changes will be in: - @spectrum-css/tokens@1.0.7.

There's also a Jira ticket about this: https://jira.corp.adobe.com/browse/CSS-240

I updated tokens to 1.0.7 @pfulton

@pfulton
Copy link
Collaborator

pfulton commented Aug 29, 2022

Thanks!

@github-actions github-actions bot temporarily deployed to pull request August 29, 2022 14:21 Inactive
@pfulton
Copy link
Collaborator

pfulton commented Aug 29, 2022

Released:
5.0.0-beta.1

@pfulton
Copy link
Collaborator

pfulton commented Aug 29, 2022

FYI, I bumped the version number to the latest beta release in the Web Components PR.

@pfulton pfulton added the pending-swc-validation Being reviewed in/by SWC; required for breaking changes label Aug 30, 2022
@yosevu yosevu mentioned this pull request Sep 7, 2022
Merged
13 tasks
Yosevu Kilonzo added 4 commits September 21, 2022 15:17
@pfulton
feat(statuslight)!: migrate statuslight to core tokens
a0a477a 
BREAKING CHANGE: migrate statuslight to core tokens
@pfulton
feat: update index.css styles
b7a315a
@pfulton
chore: remove disabled state
eaab326 
This is based on a comment in the batch 1 XD file
@pfulton
feat: colors
071f5fb
@pfulton pfulton force-pushed the yosevu/css-115-migrate-statuslight-to-core-tokens branch from d117796 to 15228c3 Compare September 21, 2022 19:19
@github-actions github-actions bot temporarily deployed to pull request September 21, 2022 19:31 Inactive
@pfulton pfulton merged commit 3dc991d into main Sep 21, 2022
@pfulton pfulton deleted the yosevu/css-115-migrate-statuslight-to-core-tokens branch September 21, 2022 19:35
This was referenced Sep 25, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhard-adobe bernhard-adobe bernhard-adobe left review comments

@pfulton pfulton pfulton approved these changes

Assignees
No one assigned
Labels
pending-swc-validation Being reviewed in/by SWC; required for breaking changes released-beta Indicates a beta release has been rolled for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yosevu @bernhard-adobe @pfulton