Remove the ability to switch language to the current language #5287
Conversation
The "Restart brackets" button will be disabled if you select the current lang in the "Switch Language" dialog. Tested on Windows 8 with Brackets 0.32 master c05cfd5
|
@SAplayer it this change really necessary? |
|
Yes, and currently it isn't. |
|
ok i see i just didn't see it happen, but now i can reproduce it when i have for example system standard selected and then select English and then again system standard, then your change comes into action. |
ghost
assigned
|
How about merging it? |
|
i'm not a committer. i assume @JeffryBooher will merge it once he has had time to do a short review. |
| @@ -151,7 +151,7 @@ define(function (require, exports, module) { | |||
|
|
|||
| function setLanguage(event) { | |||
| locale = $select.val(); | |||
| $submit.prop("disabled", false); | |||
| $submit.prop("disabled", locale === (curLocale === null ? "" : curLocale)); | |||
There was a problem hiding this comment.
use the OR operator here instead of inline IF: locale === (currLocal || "")
Thanks for the tip ;)
|
@JeffryBooher Have you reviewed it? |
|
@SAplayer sorry been heads down on another story. This looks good. Merging |
Remove the ability to switch language to the current language
The "Restart brackets" button will be disabled if you select the current
lang in the "Switch Language" dialog.
Tested on Windows 8 with Brackets 0.32 master c05cfd5