Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

JavaScript Refactoring - Rename Identifier, Wrap selection, Convert to arrow function, Create Getters & Setters #13965

Merged
merged 16 commits into from
Dec 20, 2017
Merged

JavaScript Refactoring - Rename Identifier, Wrap selection, Convert to arrow function, Create Getters & Setters #13965

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
915c0e6
Rename references using tern
Dec 7, 2017
c2b7b4d
On doc change editor was not getting updated
Dec 7, 2017
0d9cb84
Addressing review comments
Dec 7, 2017
f485ec1
First cut of wrap selection
Dec 8, 2017
b2e1d5b
Fixing issues i.e. Rename global variable, passing commonJS to tern n…
Dec 11, 2017
2cf2cc7
Wrap in condition
Dec 11, 2017
756fb9b
Code clean up
Dec 12, 2017
5ebc31e
Wrap selction, create getters setters, arrow function
Dec 16, 2017
8bd69f2
Lint error fixed
Dec 16, 2017
ce63ccc
linitng errors fixed
Dec 16, 2017
a663474
Final changes, added documentation
Dec 17, 2017
b09d1dc
Addressing review comments
Dec 18, 2017
d3e7df3
Removing get and set from getters and setter name
Dec 18, 2017
d8e0060
Addressed review comments, Fixed bug in convert to arrow function, mi…
Dec 19, 2017
3488060
linting errors fixed
Dec 19, 2017
abd80b9
linting errors fixed
Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
On doc change editor was not getting updated
  • Loading branch information
Naveen Choudhary committed Dec 7, 2017
commit c2b7b4dba55f5845919762d8880ec9b20e953d34
9 changes: 3 additions & 6 deletions src/extensions/default/JavaScriptRefactoring/RenameIdentifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ define(function (require, exports, module) {


var session = null, // object that encapsulates the current session state
refactorRename = "javascript.renamereference",
editor;
refactorRename = "javascript.renamereference";

function initializeSession(editor) {
session = new Session(editor);
Expand Down Expand Up @@ -76,10 +75,8 @@ define(function (require, exports, module) {
}

function handleRename() {
if (!editor) {
editor = EditorManager.getActiveEditor();
}
var offset, handleFindRefs;
var editor = EditorManager.getActiveEditor(),
offset, handleFindRefs;
initializeSession(editor);


Expand Down