This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed Project Manager failing tests #13368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changeset LGTM, but what happened to the |
|
It is always failing in test domain. I am yet to find a reason, when I last debugged it was sending message through websocket, there might be an issue with the shell side. |
zaggino
approved these changes
May 10, 2017
|
It'd be good to figure out what the problem is, but LGTM |
petetnt
approved these changes
May 10, 2017
|
Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues in
copyapi, I am trying to fix that. Until then we can usecopyPathto run tests. Please note thatcopyPathcannot copy binary files, so we can't use the same API inLowLevelFileIOandFindInFilesTests which are also failing as they use test files involving some images.Once copy API is fixed, then we can fix the failing tests in
LowLevelFileIOandFindInFilesas well.