Return `&str` from `BasicAuth::user_id()` and `BasicAuth::password()` #249

mcronce · 2022-05-24T04:22:34Z

PR Type

Feature/improvement

PR Checklist

Tests for the changes have been added / updated.
Documentation comments have been added / updated.
A changelog entry has been made for the appropriate packages.
Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Makes the two mentioned functions more easily usable in calling code

I would probably consider this a breaking change - the return types of public functions have changed. It might be the case that any code that compiled/worked previously will still compile, but I'm not super confident about that.

Fixes #238

…w<str> from BasicAuth::user_id() and BasicAuth::password()

JohnTitor · 2022-05-24T21:33:04Z

Does it make sense to apply the same change to Bearer::token?

actix-extras/actix-web-httpauth/src/headers/authorization/scheme/bearer.rs

Lines 37 to 40 in d11a272

    
           /// Gets reference to the credentials token. 
        
           pub fn token(&self) -> &Cow<'static, str> { 
        
               &self.token 
        
           }

robjtede

yeah, i like it

actix-web-httpauth/src/extractors/basic.rs: Return &str instead of Co…

22fbf94

…w<str> from BasicAuth::user_id() and BasicAuth::password()

robjtede requested a review from a team May 24, 2022 14:10

robjtede changed the title ~~actix-web-httpauth: Return &str instead of Cow<str> from BasicAuth::user_id() and BasicAuth::password()~~ eturn &str instead of Cow<str> from BasicAuth::user_id() and BasicAuth::password() May 24, 2022

robjtede changed the title ~~eturn &str instead of Cow<str> from BasicAuth::user_id() and BasicAuth::password()~~ Return &str instead of Cow<str> from BasicAuth::user_id() and BasicAuth::password() May 24, 2022

robjtede added A-httpauth Project: actix-web-httpauth B-semver-major breaking change requiring a major version bump labels May 24, 2022

Merge branch 'master' into close-the-barn-door

b4ee27b

robjtede approved these changes Jul 19, 2022

View reviewed changes

robjtede changed the title ~~Return &str instead of Cow<str> from BasicAuth::user_id() and BasicAuth::password()~~ Return &str from BasicAuth::user_id() and BasicAuth::password() Jul 19, 2022

robjtede enabled auto-merge (squash) July 19, 2022 01:28

robjtede merged commit 140453c into actix:master Jul 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return `&str` from `BasicAuth::user_id()` and `BasicAuth::password()` #249

Return `&str` from `BasicAuth::user_id()` and `BasicAuth::password()` #249

mcronce commented May 24, 2022 •

edited by robjtede

Loading

JohnTitor commented May 24, 2022

robjtede left a comment

Return &str from BasicAuth::user_id() and BasicAuth::password() #249

Return &str from BasicAuth::user_id() and BasicAuth::password() #249

Conversation

mcronce commented May 24, 2022 • edited by robjtede Loading

PR Type

PR Checklist

Overview

JohnTitor commented May 24, 2022

robjtede left a comment

Choose a reason for hiding this comment

Return `&str` from `BasicAuth::user_id()` and `BasicAuth::password()` #249

Return `&str` from `BasicAuth::user_id()` and `BasicAuth::password()` #249

mcronce commented May 24, 2022 •

edited by robjtede

Loading