Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require asp for AUR download #486

Closed
wants to merge 1 commit into from

Conversation

yuyichao
Copy link

Also include a reason in the error message when asp is required but missing.

Fix #485

Tested that -G <aur package> works without asp installed.
-G <official repo package> prints an error without asp and works with it installed.
Other operations like -Syuo still works.

Also include a reason in the error message when `asp` is required but missing.

Fix actionless#485
@coveralls
Copy link

coveralls commented May 23, 2020

Pull Request Test Coverage Report for Build 1800

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 87.66%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pikaur/main.py 5 7 71.43%
Totals Coverage Status
Change from base Build 1798: -0.04%
Covered Lines: 3005
Relevant Lines: 3428

💛 - Coveralls

actionless added a commit that referenced this pull request May 23, 2020
@actionless
Copy link
Owner

fixed in 9f6586d

@actionless actionless closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asp is "required" for AUR download
3 participants