CSW - Rework settings #9901
Merged
CSW - Rework settings #9901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't entirely separate. If you enable advanced assembly, you need ammo handling to be enabled.
johnb432
commented
Apr 2, 2024
Comment on lines
+9
to
+23
| if (GVAR(defaultAssemblyMode) && GVAR(ammoHandling) == 0) then { | ||
| if (isServer) then { | ||
| [QGVAR(ammoHandling), 2, 2, "server"] call CBA_settings_fnc_set; | ||
| }; | ||
|
|
||
| // Notify everyone about change | ||
| [QEGVAR(common,displayTextStructured), [composeText [ | ||
| lineBreak, | ||
| parseText format [ | ||
| "<t align='center'>%1</t>", format ["%1 requires %2 to be set higher than 0.", QGVAR(defaultAssemblyMode), QGVAR(ammoHandling)] | ||
| ], | ||
| lineBreak, | ||
| parseText format ["<t align='center'>%1</t>", "No mission restart is required."] | ||
| ], 4]] call CBA_fnc_localEvent; | ||
| }; |
There was a problem hiding this comment.
Another solution I had was to use a different set of global variables to use within the scripts. These global variables would copy the CBA settings at mission start, check if the settings are feasible, correct them accordingly and the variables wouldn't be touched after that.
There was a problem hiding this comment.
What I'm reading is CBA Settings framework could use support for child/dependent settings
johnb432
commented
Apr 2, 2024
johnb432
changed the title
LinkIsGrim
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
When a static weapon is placed down, it either remains a Vanilla weapon or is converted to CSW. If you change
GVAR(defaultAssemblyMode)mid-mission, it won't change existing static weapons, but it will change all future ones, which imo doesn't make it require a mission restart.GVAR(ammoHandling)on ifGVAR(defaultAssemblyMode)is enabled.Check Ammointeraction always available, regardless of ammo handling.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.