Babel preset: Add missing pkg files #65481
Merged
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
requested review from
gziolo,
ntwb,
nerrad and
ajitbohra
as code owners
sirreal
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
noisysocks
added
Backport to WP 6.7 Beta/RC
noisysocks
reviewed
Sep 19, 2024
|
|
||
| - Fix a bug in 8.8.1 due to missing files in the published package ([#65481](https://github.com/WordPress/gutenberg/pull/65481)). | ||
|
|
||
| ## 8.8.0 (2024-09-19) |
There was a problem hiding this comment.
These headings get generated automatically. We only have to put new changelog entries into the ## Unreleased section.
There was a problem hiding this comment.
Oh, nevermind, I see now you're fixing this entry which should have been automatically placed under ## 8.8.0 but wasn't because there was a missing ## Unreleased 🙂👍
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 19, 2024
Fix an issue where some files are not included in the published package: @wordpress/babel-preset-default@8.8.0 --- Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: sgomes <sergiomdgomes@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: b53abc2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue where some files are not included in the npm package: #65292 (comment)
How?
Add the missing files to the package's
package.jsonfilesfield.Testing Instructions
You can do
npm publish --dry-runfrom the package to see the included files. Here's a comparison with trunk:The added files from the commit are as follows:
# git diff bf639061fe54dfde3d1f80c9ddbaf02eba52fe31~ bf639061fe54dfde3d1f80c9ddbaf02eba52fe31 --diff-filter=A --name-only packages/babel-preset-default/polyfill-exclusions.js packages/babel-preset-default/replace-polyfills.js packages/babel-preset-default/test/fixtures/polyfill.js packages/dependency-extraction-webpack-plugin/test/fixtures/polyfill-magic-comment/index.js packages/dependency-extraction-webpack-plugin/test/fixtures/polyfill-magic-comment/webpack.config.js