PHP 8.3 | HasCapabilitiesTest: fix deprecation notices for ReflectionProperty::setValue() #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…Property::setValue() The `ReflectionProperty::setValue()` method supports three method signatures, two of which are deprecated as of PHP 8.3. This adjusts the call to `ReflectionProperty::setValue()` in the `HasCapabilitiesTest` to pass `null` as the "object" for setting the value of a static property to make the method call cross-version compatible. Ref: https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#reflectionpropertysetvalue
jrfnl
force-pushed
the
feature/php-8.3-fix-test-compat
branch
from
12713d1
to
fcc5625
Compare
schlessera
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReflectionProperty::setValue()method supports three method signatures, two of which are deprecated as of PHP 8.3.This adjusts the call to
ReflectionProperty::setValue()in theHasCapabilitiesTestto passnullas the "object" for setting the value of a static property to make the method call cross-version compatible.Ref: https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#reflectionpropertysetvalue