Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebAssembly.Memory constructor exception #153

Closed
annevk opened this issue Mar 19, 2020 · 0 comments · Fixed by #154
Closed

WebAssembly.Memory constructor exception #153

annevk opened this issue Mar 19, 2020 · 0 comments · Fixed by #154

Comments

@annevk
Copy link
Member

annevk commented Mar 19, 2020

If shared is true and maximum isn't given, the Bikeshed says to throw a RangeError, but #24 and implementations aligned on TypeError. Probably makes the most sense to fix the specification here.
binji added a commit that referenced this issue Mar 25, 2020
@binji
Throw RangeError for shared memory w/o maximum
c044ca1 
Fixes #153.
@binji binji mentioned this issue Mar 25, 2020
Merged
binji added a commit that referenced this issue Mar 26, 2020
@binji
Throw TypeError for shared memory w/o maximum
b54cd1e 
Instead of RangeError.

Fixes #153.
binji added a commit that referenced this issue Mar 26, 2020
@binji
Throw TypeError for shared memory w/o maximum (#154)
980c1bc 
Instead of RangeError.

Fixes #153.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw TypeError for shared memory w/o maximum WebAssembly/threads
1 participant
@annevk