Add mixtral support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.py
Outdated
| for sublayer_name in aq_handlers.keys(): | ||
| print(f"Quantizing module {sublayer_name} of layer {layer_index}") | ||
| if "mixtral" in model.config.model_type.lower() and args.mix_compression: | ||
| print("mix_compression") |
There was a problem hiding this comment.
Suggested change
| print("mix_compression") |
main.py
Outdated
| for sublayer_name in aq_handlers.keys(): | ||
| print(f"Quantizing module {sublayer_name} of layer {layer_index}") | ||
| if "mixtral" in model.config.model_type.lower() and args.mix_compression: | ||
| print("mix_compression") | ||
| assert args.nbits_per_codebook == 16 |
There was a problem hiding this comment.
Nitpicking: this looks like a very specific configuration for a general option (--mix_compression)
if you have time, can you please
- assert that model type is mixtral
- double the number of codebooks for self-attn layers
- use standard number of codebooks for non self-attn layers
If you don't have time, please
- merge this PR
- create an issue, saying
PR https://github.com/Vahe1994/AQLM/pull/12/ adds a very specific configuration for--mix_compression.
It would be great to generalize it to something more generic.
For instance, we can
- assert that model type is mixtral
- double the number of codebooks for self-attn layers
- use standard number of codebooks for non self-attn layers
justheuristic
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Mixtral support