Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use new transformation style in delete and paste #835

Merged
merged 22 commits into from
Oct 7, 2016

Conversation

johnfn
Copy link
Member

@johnfn johnfn commented Oct 4, 2016

Refactoring this massive codebase into this new style is... tough.

The more we do it, though, the more awesome multi-cursor becomes. And also, the more consistent our codebase becomes. Which is nice for anyone who wants to add stuff to it. 😉

Todo

  • 35 failing tests...
  • 32 failing tests
  • 30 failing tests
  • 26 failing tests
  • 22 failing tests
  • 21 failing tests
  • 20 failing tests
  • 19 failing tests
  • 18 failing tests
  • 16 failing tests
  • 13 failing tests
  • 1 failing test!

@xconverge
Copy link
Member

I don't really see where diff is used in a lot of cases? is there an obvious base class implementation somewhere I am missing? Trying to understand why this is good :)

@johnfn
Copy link
Member Author

johnfn commented Oct 7, 2016

@xconverge the diffs are all used in executeCommand in ModeHandler.

Essentially now the way we do cursor position updates is by a diff instead of by an exact location. This is because if you're running a command on lots of cursors in multi-cursor mode, previous inserts could offset your current location, which would invalidate locations you calculated.

@johnfn johnfn merged commit 7a2908f into master Oct 7, 2016
@jpoon jpoon deleted the use-new-transformation-style-in-delete-paste branch October 12, 2016 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants