Implement square-bracket text object #467
Conversation
| @@ -268,6 +268,14 @@ suite("Mode Normal", () => { | |||
| }); | |||
|
|
|||
| newTest({ | |||
| title: "Can handle 'ci[' spanning multiple lines", | |||
There was a problem hiding this comment.
consider adding cases for a[, a], i]?
There was a problem hiding this comment.
Yes, I wasn't sure about the level of testing desired, given that the underlying functionality (character matching) is already covered. Happy to add more tests (and that's generally my default), but wanted to be sensitive to test run times if that's a concern for this project.
There was a problem hiding this comment.
I agree, the underlying functionality is coverd and no idea to test it again. I'll suggest adding tests for corner cases then we can make sure that we don't break this feature if we want to modify the architecture somehow one day.
For example, per Vim doc for a[, When used in Visual mode it is made characterwise. while this case is linewise. Another case is i", we need take escaped " into consideration.
Not sure did I cover this kind of corner cases perfectly when I implement aw/iw, but we can together push it to the limit, what do you think? I'm not saying your test cases really miss some corner cases(I'm just not sure).
|
LGTM |
|
Thanks, @sectioneight! |
References #287