Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to ignore case when sorting #3938

Merged
merged 7 commits into from
Aug 27, 2019
Merged

added option to ignore case when sorting #3938

merged 7 commits into from
Aug 27, 2019

Conversation

noslaver
Copy link
Contributor

@noslaver noslaver commented Aug 2, 2019

Adds [i] option to sort command, which ignores case.
Fixes #3939

First contribution, please let me know if there are any problems.

@TravisBuddy
Copy link

Hey @noslaver,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0f4a2bf0-b7ba-11e9-8ff7-d1d19cf84925

Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few nits, LGTM. Thanks for the PR!

src/cmd_line/subparsers/sort.ts Outdated Show resolved Hide resolved
src/cmd_line/commands/sort.ts Outdated Show resolved Hide resolved
@J-Fields J-Fields merged commit 05683aa into VSCodeVim:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ignorecase for sort command
3 participants