Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support C #366

Merged
merged 2 commits into from
Jun 28, 2016
Merged

Support C #366

merged 2 commits into from
Jun 28, 2016

Conversation

rebornix
Copy link
Member

Delete from the cursor position to the end of the line and [count]-1 more lines [into register x], and start insert.


public async exec(position: Position, vimState: VimState): Promise<VimState> {
return new ChangeOperator().run(vimState, position, position.getLineEnd().getLeft());
}

public async execCount(position: Position, vimState: VimState): Promise<VimState> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you override execCount, you don't need to keep exec. execCount's default behavior is to call exec, but if you override it, then exec is never called.

@johnfn
Copy link
Member

johnfn commented Jun 27, 2016

Remove the old exec function and we should be good here 👍

@rebornix
Copy link
Member Author

rebornix commented Jun 28, 2016

@johnfn good catch, it's not necessary at all. To allow users not to override it every time, I remove the abstract keyword of the method definition.

@johnfn johnfn merged commit 2f9d66a into VSCodeVim:master Jun 28, 2016
@johnfn
Copy link
Member

johnfn commented Jun 28, 2016

Oh, good idea. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants