Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --grep flag to gulp test #2904

Merged
merged 9 commits into from
Jul 28, 2018
Merged

Add --grep flag to gulp test #2904

merged 9 commits into from
Jul 28, 2018

Conversation

xmbhasin
Copy link
Contributor

@xmbhasin xmbhasin commented Jul 27, 2018

What this PR does / why we need it:
Add --grep flag to gulp test for faster testing and iteration. The flag --grep takes js regex as a string and filters by test and test suite names. Also works with the default task since it includes gulp test (eg gulp --grep foldFix).
Which issue(s) this PR fixes

Special notes for your reviewer:

@jpoon
Copy link
Member

jpoon commented Jul 27, 2018

Oh, man. This is awesome.

@xmbhasin
Copy link
Contributor Author

I think I'm done making changes to this PR for now, but I could also quickly add other mocha test options as gulp test flags if you think any would be useful.

@xconverge
Copy link
Member

Really appreciate it, none of the other mocha test options scream out to me as super useful right now

@jpoon jpoon merged commit 1e1e8b0 into VSCodeVim:master Jul 28, 2018
@xmbhasin xmbhasin deleted the mocha-grep branch July 28, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants