Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor motions #288

Merged
merged 6 commits into from
Jun 11, 2016
Merged

Refactor motions #288

merged 6 commits into from
Jun 11, 2016

Conversation

johnfn
Copy link
Member

@johnfn johnfn commented Jun 11, 2016 •
edited
Loading

  • Motions now just return a single position - or at worse a 3 tuple of start, end and (unfortunately) register mode
  • Special case motion handling in modeHandler. This greatly simplifies the core loop. I was trying to be too clever before by not special casing motions before.

@johnfn johnfn merged commit 42f3866 into master Jun 11, 2016
@jpoon jpoon deleted the refactor-motions branch June 13, 2016 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnfn