Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add easymotion-lineforward and easymotion-linebackward #2596

Merged
merged 20 commits into from
May 6, 2018

Conversation

hyhugh
Copy link
Contributor

@hyhugh hyhugh commented May 3, 2018

What this PR does / why we need it:

add two new easymotion commands

easymotion-lineforward and easymotion-linebackward

The behaviour of these two commands are slightly different from the original easymotion because the current easymotion implementation doesn't allow me to limit the search within a line.

Special notes for your reviewer: Sorry for the messy commit logs, i dk why the last PR's(which is already merged) commit logs are still there.

@xconverge
Copy link
Member

Is this exactly the same as regular easymotion? Do you have some configs in your vimrc for easymotion?

I am looking here and it looks like a configurable option but only uses single leader presses not double

https://github.com/easymotion/vim-easymotion#hjkl-motions

@hyhugh
Copy link
Contributor Author

hyhugh commented May 3, 2018

There is no default mapping for lineforward and linebackward command in vim-easymotion. So i followed both the current vscodevim convention(which uses double leaders for word and line moving) and the configuration in the readme of vim-easymotion(which uses l and h as lineforward and backward).
btw, Actually all the default mappings for vim-easymotion use single leader.
wx20180504-024337

@xconverge
Copy link
Member

Can you add a test for each to the plugins/easymotion test please? Thanks!

@xconverge
Copy link
Member

Thank you very much!

@xconverge xconverge merged commit 57b2b46 into VSCodeVim:master May 6, 2018
@hyhugh
Copy link
Contributor Author

hyhugh commented May 6, 2018

Thank you for merging~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants