Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2063 #2079

Merged
merged 5 commits into from
Oct 20, 2017
Merged

Fix #2063 #2079

merged 5 commits into from
Oct 20, 2017

Conversation

Strafos
Copy link
Contributor

@Strafos Strafos commented Oct 18, 2017

Surround in visual mode goes one less character.

@@ -835,4 +835,13 @@ suite('Mode Visual', () => {
assertEqualLines(['oneone two three']);
});
});

suite('vi{ will go to end of second to last line', () => {
newTestOnly({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the Only and this is good to go!

@xconverge
Copy link
Member

LGTM once you remove the newTestOnly specifier, thanks!

@jpoon jpoon self-requested a review October 19, 2017 01:10
@Chillee Chillee merged commit 14deb22 into VSCodeVim:master Oct 20, 2017
@Chillee
Copy link
Member

Chillee commented Oct 20, 2017

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants