Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1503: Undo history isn't kept when switching tabs #1629

Merged
merged 2 commits into from
May 4, 2017

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented May 2, 2017

It seems that whenever we switch editors, we don't have access to cursorPosition until after the stack clears?

Whatever it is, it's similar to this PR: #1605

@johnfn
Copy link
Member

johnfn commented May 3, 2017

Yeah that is weird and probably should be investigated further.

This is good to go though? No bad conflict with e.g. gd I assume? :)

@Chillee
Copy link
Member Author

Chillee commented May 3, 2017

It all seems to work for me. gd works properly, undo history seems to work even when switching files, whether it's from gd or ctrl+tab.

After playing around with it for 5 minutes or so, I couldn't get it to break, so I think it's good to go.

@xconverge xconverge merged commit 31319c9 into VSCodeVim:master May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants