-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove our modified older typings #1367
Remove our modified older typings #1367
Conversation
So is this ready to go? CAN I PULL IT? CAN I PRESS THE BIG RED BUTTON |
haha branchname |
There needs to be an emoji better than laughing for how I feel about that branch name |
What do we do when I do want it merged lol |
When 1.6 came out, I looked into doing this but the crazy amount of builds errors made me rethink that so @xconverge thanks for taking this on. |
Yea I am an idiot |
total cop out here for dealing with strictNullChecks... |
doing these updates:
https://code.visualstudio.com/updates/v1_6#_extension-authoring
So that we can use v1.0.5 of the vscode.d.ts node module:
microsoft/vscode-extension-vscode#53