Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: unit tests are failing on Windows #88

Closed
jpoon opened this issue Dec 3, 2015 · 0 comments
Closed

Tests: unit tests are failing on Windows #88

jpoon opened this issue Dec 3, 2015 · 0 comments
Labels

Comments

@jpoon
Copy link
Member

jpoon commented Dec 3, 2015

I suspect this is due to the differences in CRLF among the platforms. It maybe easier to test against the current location of the cursor rather then checking for the text.

  1) Mode Insert Can handle 'o':
      AssertionError: 'text' == 'text\n'
      + expected - actual
      -text
      +text

      at Object.assertTextEditorText (d:\Source\VSCodeVim\test\testUtils.ts:12:9)
      at d:\Source\VSCodeVim\test\mode\modeInsert.test.ts:48:34
      at Object.p [as _notify] (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1440:1)
      at Object.__dirname.undefined.L.enter (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1127:1)
      at [object Object].__dirname.undefined.t.Class.define._run (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1343:1)
      at [object Object].__dirname.undefined.t.Class.define._completed (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1311:1)
      at Object.p [as _notify] (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1440:1)
      at Object.__dirname.undefined.L.enter (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1127:1)
      at [object Object].__dirname.undefined.t.Class.define._run (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1343:1)
      at [object Object].__dirname.undefined.t.Class.define._completed (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1311:1)

2) Mode Insert Can handle 'O':
      AssertionError: '\r\ntext' == '\ntext'
      + expected - actual
      -
      +
       text

      at Object.assertTextEditorText (d:\Source\VSCodeVim\test\testUtils.ts:12:9)
      at d:\Source\VSCodeVim\test\mode\modeInsert.test.ts:59:34
      at Object.p [as _notify] (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1440:1)
      at Object.__dirname.undefined.L.enter (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1127:1)
      at [object Object].__dirname.undefined.t.Class.define._run (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1343:1)
      at [object Object].__dirname.undefined.t.Class.define._completed (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1311:1)
      at Object.p [as _notify] (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1440:1)
      at Object.__dirname.undefined.L.enter (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1127:1)
      at [object Object].__dirname.undefined.t.Class.define._run (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1343:1)
      at [object Object].__dirname.undefined.t.Class.define._completed (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\vs\workbench\node\vs\base\common\winjs.base.raw.js:1311:1)
@jpoon jpoon added the kind/bug label Dec 4, 2015
jpoon added a commit that referenced this issue Dec 4, 2015
jpoon added a commit that referenced this issue Dec 4, 2015
@jpoon jpoon mentioned this issue Dec 4, 2015
@jpoon jpoon closed this as completed in #92 Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant