Text input between quotes is slow

[f111fei]

What did you do?

1. Install vim extension.

2. open a large js file. e.g : https://code.jquery.com/jquery-3.1.1.js

3. Typing I switch to insert mode.

4. Typing " and other letters (e.g: "Hello") at first line. The other letters takes a long time to appear.

Technical details:

• VSCode Version: 1.9.0
• VsCodeVim Version: 0.5.3
• OS: windows7 and mac

[johnfn]

Easy to reproduce. Also very weird.

[xconverge]

Yep good catch!

[xconverge]

I think that this is definitely a large document vs small document issue... I can't reproduce it in smaller files, it has to be a larger file

[xconverge]

Ok almost 100% sure this is the culprit, related to something I did I think. And if so it is bad. We have a check in modehandler to create undo points when brackets are open/closed. It executes this:

  if (vimState.currentMode === ModeName.Insert) {
      // Check if the keypress is a closing bracket to a corresponding opening bracket right next to it
      let result = PairMatcher.nextPairedChar(vimState.cursorPosition, key, false);
      if (result !== undefined) {
        if (vimState.cursorPosition.compareTo(result) === 0) {
          return true;
        }
      }

      result = PairMatcher.nextPairedChar(vimState.cursorPosition.getLeft(), key, true);
      if (result !== undefined) {
        if (vimState.cursorPosition.getLeftByCount(2).compareTo(result) === 0) {
          return true;
        }
      }
    }

In nextPairedChar we iterate the whole document....only to check if the character is right next to it.

This should be an easy fix to just check the characters adjacent in for the correct match, instead of the whole document THEN comparing location.