Skip to content

Commit

Permalink
Removed solid block cursor
Browse files Browse the repository at this point in the history
  • Loading branch information
Chillee committed Jun 15, 2017
1 parent e1b9940 commit de83e92
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 18 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,7 @@ These settings are specific to VSCodeVim.
* Type: Color String (Default: `rgba(150, 150, 150, 0.3)`)

#### `"vim.useSolidBlockCursor"`
* Use a non-blinking block cursor
* Type: Boolean (Default: `false`)
We have removed this option, due to it making VSCodeVim's performance suffer immensely.

#### `"vim.useCtrlKeys"`
* Enable Vim ctrl keys overriding common VS Code operations (eg. copy, paste, find, etc). Enabling this setting will:
Expand Down
5 changes: 0 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,6 @@
"description": "Timeout in milliseconds for remapped commands",
"default": 1000
},
"vim.useSolidBlockCursor": {
"type": "boolean",
"description": "Use a non blinking block cursor.",
"default": false
},
"vim.scroll": {
"type": "number",
"description": "Number of lines to scroll with CTRL-U and CTRL-D commands.",
Expand Down
4 changes: 0 additions & 4 deletions src/configuration/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,6 @@ class ConfigurationClass {
}
}

/**
* Should the block cursor not blink?
*/
useSolidBlockCursor = false;

/**
* Use the system's clipboard when copying.
Expand Down
7 changes: 0 additions & 7 deletions src/mode/modeHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1712,13 +1712,6 @@ export class ModeHandler implements vscode.Disposable {

let cursorRange: vscode.Range[] = [];

// Draw block cursor.
if (Configuration.useSolidBlockCursor) {
await vscode.workspace
.getConfiguration("editor")
.update("cursorBlinking", this.currentMode.name !== ModeName.Insert ? "solid" : "blink", true);
}

// Use native cursor if possible. Default to Block.
let cursorStyle = vscode.TextEditorCursorStyle.Block;
switch (this.currentMode.cursorType) {
Expand Down

0 comments on commit de83e92

Please sign in to comment.