[WIP] Making UpSet an npm module #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jeff, this is great! I'll test it over the weekend and merge then! |
|
Thanks! Note that your nice permalinking routing is disabled on this PR. I'm ok if you put those back in (a few commented lines that call |
|
I merged this - the queryParameters implementation is unfortunately rather buggy anyways, so we're not missing a ton here. |
|
Thanks @alexsb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does several small things to make UpSet close to a reusable module.
package.json<body>with fontdatasetsparameter to UpSet initialization that will enable dynamic or inlined data.To do:
updateQueryParametersan option so if embedded in another app it does not modify the window URL location (currently this logic is commented out)Note: It seems "upset" is not taken on npm so it could be placed there.